(CAT-2548): Revert "Rubocop safe autocorrections" by span786 · Pull Request #559 · puppetlabs/puppetlabs-inifile

span786 · 2026-02-16T05:13:15Z

Summary

This reverts commit 64aaa08.

These changes are causing compatibility problems with Ruby 2.x while providing no measurable improvements in performance.

Checklist

🟢 Spec tests.
🟢 Acceptance tests.
Manually verified. (For example puppet apply)

This reverts commit 64aaa08.

span786 · 2026-02-16T08:08:56Z

I tested this on Puppet 7.x, and the execution log is provided below:

test file used : test_inifile.pp.zip

[litmuskr5b70m@litmus-9f5397faa9d2feba ~]$ sudo su

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# puppet agent --version
7.34.0

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.10 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.10"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.10 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8"
BUG_REPORT_URL="https://issues.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.10
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.10"

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# vi test_inifile.pp

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# puppet module list
/etc/puppetlabs/code/environments/production/modules
├── puppetlabs-inifile (v6.3.0)
└── puppetlabs-stdlib (v9.7.0)
/etc/puppetlabs/code/modules (no modules installed)
/opt/puppetlabs/puppet/modules (no modules installed)

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# puppet apply test_inifile.pp --verbose
Info: Loading facts
Notice: Compiled catalog for litmus-9f5397faa9d2feba.c.ia-content.internal in environment production in 0.06 seconds
Info: Using environment 'production'
Info: Applying configuration version '1771228038'
Notice: /Stage[main]/Main/File[/tmp/inifile_tests]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting_port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting_username]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_separator]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[no_space_separator]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_section_format]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_indent]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_indent_spaces]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_xmx]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_xms]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_heap_dump]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] host]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] database]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] ssl]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] host]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] db]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [application] debug]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [application] cache]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_timeout]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_keepalive]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_max_clients]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_max_execution_time]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_memory_limit]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_error_reporting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[global_setting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[special_chars_in_value]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[url_value]/ensure: created
Notice: INI file tests have been applied. Check /tmp/inifile_tests/ for results.
Notice: /Stage[main]/Main/Notify[inifile_tests_completed]/message: defined 'message' as 'INI file tests have been applied. Check /tmp/inifile_tests/ for results.'
Notice: Applied catalog in 0.04 seconds

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# ls -lath /tmp/inifile_tests/
total 48K
-rw-r--r--.  1 root root  137 Feb 16 07:47 special.ini
drwxr-xr-x.  2 root root 4.0K Feb 16 07:47 .
-rw-r--r--.  1 root root   16 Feb 16 07:47 global.ini
-rw-r--r--.  1 root root  102 Feb 16 07:47 php.ini
-rw-r--r--.  1 root root   71 Feb 16 07:47 apache.conf
-rw-r--r--.  1 root root  170 Feb 16 07:47 config.ini
-rw-r--r--.  1 root root   61 Feb 16 07:47 java.conf
-rw-r--r--.  1 root root   52 Feb 16 07:47 indented.ini
-rw-r--r--.  1 root root   22 Feb 16 07:47 custom_section.ini
-rw-r--r--.  1 root root   42 Feb 16 07:47 custom.ini
-rw-r--r--.  1 root root   57 Feb 16 07:47 basic.ini
drwxrwxrwt. 10 root root 4.0K Feb 16 07:47 ..

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# cat /tmp/inifile_tests/global.ini
version = 1.0.0

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# cat /tmp/inifile_tests/php.ini
[PHP]
max_execution_time = 60
memory_limit = 256M
error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT

[root@litmus-9f5397faa9d2feba litmuskr5b70m]# cat /tmp/inifile_tests/apache.conf
[general]
Timeout = 300
KeepAlive = On

[mpm_prefork]
MaxClients = 150

[root@litmus-9f5397faa9d2feba litmuskr5b70m]#

span786 · 2026-02-16T08:11:49Z

I also tested this on Puppet 8.x, and the execution log is provided below:

test file used : same one used for Puppet 7.x

[litmus4w1w7o6e@litmus-f499e7bbb5b2e3dc ~]$ sudo su

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.10 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.10"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.10 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8"
BUG_REPORT_URL="https://issues.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.10
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.10"

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# puppet agent --version
8.16.0

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# puppet module list
/etc/puppetlabs/code/environments/production/modules
├── puppetlabs-inifile (v6.3.0)
└── puppetlabs-stdlib (v9.7.0)
/etc/puppetlabs/code/modules (no modules installed)
/opt/puppetlabs/puppet/modules (no modules installed)

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# vi test_inifile.pp

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# puppet apply test_inifile.pp --verbose
Info: Loading facts
Notice: Compiled catalog for litmus-f499e7bbb5b2e3dc.c.ia-content.internal in environment production in 0.07 seconds
Info: Using environment 'production'
Info: Applying configuration version '1771228924'
Notice: /Stage[main]/Main/File[/tmp/inifile_tests]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting_port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[basic_setting_username]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_separator]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[no_space_separator]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_section_format]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_indent]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[custom_indent_spaces]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_xmx]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_xms]/ensure: created
Notice: /Stage[main]/Main/Ini_subsetting[java_heap_dump]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] host]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] database]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [mysql] ssl]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] host]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] port]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [redis] db]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [application] debug]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[/tmp/inifile_tests/config.ini [application] cache]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_timeout]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_keepalive]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[apache_max_clients]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_max_execution_time]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_memory_limit]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[php_error_reporting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[global_setting]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[special_chars_in_value]/ensure: created
Notice: /Stage[main]/Main/Ini_setting[url_value]/ensure: created
Notice: INI file tests have been applied. Check /tmp/inifile_tests/ for results.
Notice: /Stage[main]/Main/Notify[inifile_tests_completed]/message: defined 'message' as 'INI file tests have been applied. Check /tmp/inifile_tests/ for results.'
Notice: Applied catalog in 0.05 seconds

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# ls -lath /tmp/inifile_tests/
total 48K
-rw-r--r--.  1 root root  137 Feb 16 08:02 special.ini
drwxr-xr-x.  2 root root 4.0K Feb 16 08:02 .
-rw-r--r--.  1 root root   16 Feb 16 08:02 global.ini
-rw-r--r--.  1 root root  102 Feb 16 08:02 php.ini
-rw-r--r--.  1 root root   71 Feb 16 08:02 apache.conf
-rw-r--r--.  1 root root  170 Feb 16 08:02 config.ini
-rw-r--r--.  1 root root   61 Feb 16 08:02 java.conf
-rw-r--r--.  1 root root   52 Feb 16 08:02 indented.ini
-rw-r--r--.  1 root root   22 Feb 16 08:02 custom_section.ini
-rw-r--r--.  1 root root   42 Feb 16 08:02 custom.ini
-rw-r--r--.  1 root root   57 Feb 16 08:02 basic.ini
drwxrwxrwt. 10 root root 4.0K Feb 16 08:02 ..

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# cat /tmp/inifile_tests/apache.conf
[general]
Timeout = 300
KeepAlive = On

[mpm_prefork]
MaxClients = 150

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# cat /tmp/inifile_tests/indented.ini
[formatting]
	use_tabs = true
    use_spaces = true

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]# cat /tmp/inifile_tests/special.ini
[paths]
log_path = /var/log/app/${APP_NAME}/current.log

[api]
endpoint = https://api.example.com:8443/v1/resource?key=value&format=json

[root@litmus-f499e7bbb5b2e3dc litmus4w1w7o6e]#

span786 added 2 commits February 16, 2026 10:40

Revert "Rubocop safe autocorrections"

d409e4c

This reverts commit 64aaa08.

(CAT-2548): Disable HashSyntax style in RuboCop configuration

b9aace6

span786 marked this pull request as ready for review February 16, 2026 08:11

span786 requested review from a team, bastelfreak, ekohl and smortex as code owners February 16, 2026 08:11

shubhamshinde360 approved these changes Feb 17, 2026

View reviewed changes

amitkarsale approved these changes Feb 17, 2026

View reviewed changes

span786 merged commit 8309b9b into main Feb 17, 2026
110 of 114 checks passed

span786 deleted the CAT-2548-issue-with-puppetlabs-inifile-version-6-3-0 branch February 17, 2026 12:02

span786 added the bugfix label Feb 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(CAT-2548): Revert "Rubocop safe autocorrections"#559

(CAT-2548): Revert "Rubocop safe autocorrections"#559
span786 merged 2 commits into
mainfrom
CAT-2548-issue-with-puppetlabs-inifile-version-6-3-0

span786 commented Feb 16, 2026 •

edited

Loading

Uh oh!

span786 commented Feb 16, 2026

Uh oh!

span786 commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

span786 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

span786 commented Feb 16, 2026

Uh oh!

span786 commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

span786 commented Feb 16, 2026 •

edited

Loading